add redis and executor services into docker-compose files#12
Open
add redis and executor services into docker-compose files#12
Conversation
adarshm11
reviewed
Apr 10, 2026
Dockerfile
Outdated
Comment on lines
+27
to
+35
|
|
||
|
|
||
| FROM python3.12-slim | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # entrypoint lets us pipe stdin and returns stdout | ||
|
|
||
| ENTRYPOINT ["python", "/code/solution.py"] |
Contributor
There was a problem hiding this comment.
this stuff should be in its own file Dockerfile.python since the runner is a separate service from the Go backend
docker-compose.yml
Outdated
| retries: 5 | ||
| executor: | ||
| build: | ||
| context: ./executor |
Contributor
There was a problem hiding this comment.
Suggested change
| context: ./executor | |
| context: . |
typo in the issue
docker-compose.dev.yml
Outdated
| executor: | ||
| # docker can only access files in /executor | ||
| build: | ||
| context: ./executor |
Contributor
There was a problem hiding this comment.
Suggested change
| context: ./executor | |
| context: . |
typo in the issue
adarshm11
reviewed
Apr 11, 2026
Contributor
adarshm11
left a comment
adarshm11
left a comment
There was a problem hiding this comment.
also create a new Dockerfile for building and running the executor service, assume this is at cmd/runner/main.go and is done like any normal Go service. then this Dockerfile.executor can be referenced in the docker-compose as how to run the executor service
docker/Dockerfile.python
Outdated
Comment on lines
+2
to
+7
|
|
||
| WORKDIR /app | ||
|
|
||
| # entrypoint lets us pipe stdin and returns stdout | ||
|
|
||
| ENTRYPOINT ["python", "/code/solution.py"] No newline at end of file |
Contributor
There was a problem hiding this comment.
all of this stuff will be invoked by the Go service when queried, all this file needs to have is the image line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for numba 1 in issue #11. tbh how do you even test dis.