Implement reduced quintic triangle element#89
Open
Sichao25 wants to merge 5 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Solve A*X = B using our LU solver (row-major) | ||
| int info = solveLU_internal(20, 18, &A[0][0], 20, &B[0][0], 18); |
Contributor
Author
|
@jacobmerson @Joshua-Kloepfer This is ready for view when you have a chance. |
jacobmerson
reviewed
Jun 21, 2026
| ReducedQuinticTriangleShape>) { | ||
| assert(elemCoeffs.data() != nullptr); | ||
| auto coeffSlice = Kokkos::subview(elemCoeffs, ent, Kokkos::ALL()); | ||
| return shapeFn.getValues(localCoord, coeffSlice); |
Contributor
There was a problem hiding this comment.
@cwsmith @Joshua-Kloepfer the way we are doing this may warrant some discussion since the getValues requires additional geometric information.
This may come down to how we want to handle/formalize non-isoparametric elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reduced quintic triangle element defines 6 DOFs per vertex. The element uses a local coordinate system rather than barycentric coordinates. The evaluation introduces a set of coefficients defined by the geometric parameters of each element.