Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces dynamic statistical data (duration, altitude, and calories) with hardcoded test values in the record screen. The reviewer pointed out that these hardcoded values should be reverted to dynamic data for production and also identified a typo in the original code where the altitude unit was incorrectly labeled as 'Nm' instead of 'm', providing a code suggestion to resolve both issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| { label: "소요시간", value: "3시간 24분" }, | ||
| { label: "고도", value: "642m" }, | ||
| { label: "칼로리", value: "1128kcal" }, |
There was a problem hiding this comment.
테스트를 위해 통계 데이터를 하드코딩한 부분은 실제 서비스에 반영되기 전에 동적 데이터를 사용하도록 되돌려야 합니다.
추가로, 기존 코드에서 고도 단위가 ${Math.round(recordDetail.ascentMeters)}Nm로 표기되어 Nm이라는 오타가 있었습니다. 이를 올바른 단위인 m으로 수정하여 복원하는 것을 제안합니다.
| { label: "소요시간", value: "3시간 24분" }, | |
| { label: "고도", value: "642m" }, | |
| { label: "칼로리", value: "1128kcal" }, | |
| { label: "소요시간", value: formatDuration(recordDetail?.durationSeconds ?? durationSec) }, | |
| { label: "고도", value: recordDetail?.ascentMeters != null ? Math.round(recordDetail.ascentMeters) + "m" : "--" }, | |
| { label: "칼로리", value: recordDetail?.calories != null ? recordDetail.calories + "kcal" : "--" }, |
Summary
Test plan