Conversation
Closes SIMPLE-AstroDB#189, moving reference tables Closes SIMPLE-AstroDB#207, closes SIMPLE-AstroDB#208, closes SIMPLE-AstroDB#209 -- updating some packages, including matching js static libs.
SQL query. Improves functionality for handling references coming out of sql_query with different dimensions.
|
This looks like progress -- great work! But I think review should really come from @dr-rodriguez . Please keep in mind that SIMPLE should be using a Reference issue: SIMPLE-AstroDB/SIMPLE-db#672 |
dr-rodriguez
left a comment
There was a problem hiding this comment.
Looks like there are 4 functions added in utils.py, which has a test module. We should add tests for these 4 functions, particularly since they focus mainly on manipulating strings.
| from tqdm import tqdm # progress bars | ||
| from werkzeug.exceptions import HTTPException # underlying http | ||
| from wtforms import StringField, SubmitField, TextAreaField, ValidationError # web forms | ||
| from simple import REFERENCE_TABLES |
There was a problem hiding this comment.
This will break with the recent changes because the init file has been removed in favor of a database.toml file
| Werkzeug==3.1.4 | ||
| Werkzeug==3.1.5 | ||
| WTForms==3.2.1 | ||
| simple @ git+https://github.com/SIMPLE-AstroDB/SIMPLE-db No newline at end of file |
There was a problem hiding this comment.
Instead of importing simple, we want to update the cronjob so that it pulls the database.toml from from github and then imports it:
from astrodb_utils.loaders import DatabaseSettings
db_settings=DatabaseSettings(settings_file="database.toml")
REFERENCE_TABLES = db_settings.lookup_tables
|
The cronjob.sh needs to read: I recommend including this in this PR as per #212 |
|
I tested this in a codespace but don't have permissions to push to this branch, let us know how you want to proceed with these @Will-Cooper |
|
I've made the cronjob changes and included it in git. Database.toml wasn't as clear, as we also need a data folder as well as schema.yaml in the same directory too - I've included some logic to do so |
We ran into this issue while testing and opted instead to use tomlib: This uses the database.toml file without the extra requirements of the data folder or schema file. |
Looking across several issues, updating versions and some documentation.
Should also close #180 with some logic changes, since underlying package updates.
Makes sqllite file downloadable, adds a link to the json.
Spectra also now downloadable from raw query.