Update Fig. 4 and 5#51
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the plotting scripts and generated SVG used for “Fig. 4 and 5” style/performance figures, aligning annotations and adding additional views for prediction visualization.
Changes:
visualiseTrainingData.py: disables 3D axis indicators by default and adds a cross-section line with P0/P1 markers in the XY atomic view.visualisePredictionsPureOnlyBoth.py: switches AFM inputs to NPZ-backed slices with a shared normalization + colorbar, and adds an XZ row under each predicted XY structure panel.- Regenerates
results/train_data/style_difference.svg(metadata + internal IDs updated).
Reviewed changes
Copilot reviewed 2 out of 26 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/performanceEvaluation/visualiseTrainingData.py | Adds cross-section and P0/P1 markers; gates axis indicator drawing behind showIndicator. |
| src/performanceEvaluation/visualisePredictionsPureOnlyBoth.py | Refactors figure layout to include XZ panels; loads AFM slices from NPZ with shared color scaling and adds a colorbar. |
| results/train_data/style_difference.svg | Updated generated figure output (timestamp/tooling metadata and SVG element IDs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+611
to
+612
| if showIndicator: | ||
| draw_3d_axis_indicator(ax1, anchor=(0.85, 0.65), length=36, style='x-out') |
Comment on lines
+89
to
+99
| for i, sample in enumerate(samples): | ||
| npz_file = '{}/{}.npz'.format(expNpz, sample) | ||
| npz_data = np.load(npz_file) | ||
| exp_data = npz_data['data'] | ||
| close = exp_data[:, :, indexes[i][0]] | ||
| far = exp_data[:, :, indexes[i][1]] | ||
| close = np.rot90(close, k=(angle+90)//90) | ||
| far = np.rot90(far, k=(angle+90)//90) | ||
| x_size_nm = float(npz_data['lengthX']) / 10.0 | ||
| y_size_nm = float(npz_data['lengthY']) / 10.0 | ||
| exp_slices[sample] = (close, far, x_size_nm, y_size_nm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.