[FIX]: Change URLs in npm install command#857
Closed
MacOS wants to merge 5 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned git URLs used to install Antora-related npm dependencies in the docs Docker image, intended to fix a broken npm install introduced by PR #848.
Changes:
- Replaces GitLab/GitHub “tree/commit page” URLs with git-repository URLs intended to be installable by npm.
- Keeps commit-hash pinning for reproducible, integrity-preserving installs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
55
to
59
| RUN npm init -y && npm i --save-exact \ | ||
| https://gitlab.com/antora/antora/-/tree/aa33c8283f9cbc76df93201bec5f8421e8f59a43/packages/cli \ | ||
| https://gitlab.com/antora/antora/-/tree/aa33c8283f9cbc76df93201bec5f8421e8f59a43/packages/site-generator \ | ||
| https://gitlab.com/antora/antora-lunr-extension/-/commit/41975fc8f62cb2219a2de2f618de1ae1482bd0ce \ | ||
| https://github.com/mermaid-js/mermaid-cli/tree/a85b11df7064498d5b6b97ee9b2d4a7c10cb42ae \ | ||
| https://gitlab.com/antora/antora.git#aa33c8283f9cbc76df93201bec5f8421e8f59a43 \ | ||
| https://gitlab.com/antora/antora-lunr-extension.git#41975fc8f62cb2219a2de2f618de1ae1482bd0ce \ | ||
| https://github.com/mermaid-js/mermaid-cli.git#a85b11df7064498d5b6b97ee9b2d4a7c10cb42ae \ | ||
| https://github.com/asciidoctor/asciidoctor-kroki.git#d02fbf06cdb837524f5e4e12537c05e0bb83c715 \ |
Collaborator
Author
|
This is not done yet - I will continue tomorrow! |
Contributor
|
@MacOS after you are done, I will probably reuse your work and move the docker/antora docs generating related code into a seprate repository and reuse it from other SKaiNET-family repositories. |
Collaborator
Author
|
@michalharakal I will continue tomorrow. |
…then installing the two packages
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+61
to
+67
| RUN git clone https://gitlab.com/antora/antora.git \ | ||
| && cd antora \ | ||
| && git checkout aa33c8283f9cbc76df93201bec5f8421e8f59a43 \ | ||
| && cd packages/cli \ | ||
| && npm install --save-exact \ | ||
| && cd ../packages/site-generator \ | ||
| && npm install --save-exact |
Comment on lines
+61
to
+67
| RUN git clone https://gitlab.com/antora/antora.git \ | ||
| && cd antora \ | ||
| && git checkout aa33c8283f9cbc76df93201bec5f8421e8f59a43 \ | ||
| && cd packages/cli \ | ||
| && npm install --save-exact \ | ||
| && cd ../packages/site-generator \ | ||
| && npm install --save-exact |
…hould remove the directory not found error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
PRfixes the brokennpmsinstall by changing the URLs, the bug was introduced byPR#848.