Skip to content

[BUILD]: Pin serve install with commit hash#871

Draft
MacOS wants to merge 1 commit into
SKaiNET-developers:developfrom
MacOS:documentation-workflow/add-commit-hash-to-serve-install
Draft

[BUILD]: Pin serve install with commit hash#871
MacOS wants to merge 1 commit into
SKaiNET-developers:developfrom
MacOS:documentation-workflow/add-commit-hash-to-serve-install

Conversation

@MacOS

@MacOS MacOS commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

This PR pins the npm install -g serve with it's commit hash in documentation.yml, and hereby increases the security of the project.

This PR changes the npm install of serve such that the commit hash is used. We do this by installing the package from GitHub. The OpenSSF score should improve after this PR has been merged.

@MacOS
MacOS requested review from Copilot and michalharakal July 24, 2026 10:06
@MacOS MacOS self-assigned this Jul 24, 2026
@MacOS MacOS added the enhancement New feature or request label Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases supply-chain security for the documentation preview workflow by pinning the serve CLI installation to a specific upstream Git commit (corresponding to v14.2.6) rather than installing the latest version from npm.

Changes:

  • Replace npm install -g serve with a GitHub-commit-pinned install of vercel/serve in the documentation workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- name: Install serve package
run: npm install -g serve
run: npm install -g git+https://github.com/vercel/serve.git#f3c702c6bb312c6d6b05315721a6d3ea245d86b8 #v14.2.6
@michalharakal

Copy link
Copy Markdown
Contributor

Thank you @MacOS

@MacOS
MacOS marked this pull request as draft July 24, 2026 10:29
@MacOS

MacOS commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

I am making thie PR a draft because it seems that there is a BUG in npm when one installs a package globally from a repository - see npm/cli#8440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants