Skip to content

feat(nn): make Linear open for adapter subclasses #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalharakal merged 1 commit into from
Jul 24, 2026
+8 −3
Merged

feat(nn): make Linear open for adapter subclasses #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion skainet-lang/skainet-lang-core/api/android/skainet-lang-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ public abstract class sk/ainet/lang/nn/InternalMixedPrecisionModule : sk/ainet/l
protected abstract fun forwardImpl (Lsk/ainet/lang/tensor/Tensor;)Lsk/ainet/lang/tensor/Tensor;
}

public final class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/lang/nn/topology/ModuleParameters {
public class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/lang/nn/topology/ModuleParameters {
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;)V
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/lang/tensor/Tensor;)V
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/lang/tensor/Tensor;Z)V
Expand All @@ -764,6 +764,7 @@ public final class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/l
public fun getName ()Ljava/lang/String;
public fun getParams ()Ljava/util/List;
public final fun getTrainable ()Z
protected fun onForward (Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/context/ExecutionContext;)Lsk/ainet/lang/tensor/Tensor;
}

public final class sk/ainet/lang/nn/MaxPool2d : sk/ainet/lang/nn/Module {
Expand Down
3 changes: 2 additions & 1 deletion skainet-lang/skainet-lang-core/api/jvm/skainet-lang-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ public final class sk/ainet/lang/nn/LayerScale : sk/ainet/lang/nn/Module, sk/ain
public fun getParams ()Ljava/util/List;
}

public final class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/lang/nn/topology/ModuleParameters {
public class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/lang/nn/topology/ModuleParameters {
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;)V
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/lang/tensor/Tensor;)V
public fun <init> (IILjava/lang/String;Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/lang/tensor/Tensor;Z)V
Expand All @@ -999,6 +999,7 @@ public final class sk/ainet/lang/nn/Linear : sk/ainet/lang/nn/Module, sk/ainet/l
public fun getName ()Ljava/lang/String;
public fun getParams ()Ljava/util/List;
public final fun getTrainable ()Z
protected fun onForward (Lsk/ainet/lang/tensor/Tensor;Lsk/ainet/context/ExecutionContext;)Lsk/ainet/lang/tensor/Tensor;
}

public final class sk/ainet/lang/nn/Lstm : sk/ainet/lang/nn/Module, sk/ainet/lang/nn/topology/ModuleParameters {
Expand Down
5 changes: 4 additions & 1 deletion skainet-lang/skainet-lang-core/src/commonMain/kotlin/sk/ainet/lang/nn/Linear.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ import sk.ainet.lang.nn.topology.weights
* heads. A bias-less layer registers only the weight parameter, so parameter
* counts and checkpoints match architectures defined without bias.
*
* The class is `open` so adapter-style layers (e.g. LoRA) can subclass it and
* augment [onForward] or [params] while reusing the base projection.
*
* @param inFeatures Number of input features
* @param outFeatures Number of output features
* @param name Name of the module
* @param initWeights Initial weights
* @param initBias Initial bias, or `null` for a layer without bias
*/

public class Linear<T : DType, V> @kotlin.jvm.JvmOverloads constructor(
public open class Linear<T : DType, V> @kotlin.jvm.JvmOverloads constructor(
inFeatures: Int,
outFeatures: Int,
override val name: String = "Linear",
Expand Down
Loading