Fix Raman invariant preparation - #33
Draft
mesonepigreco wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add=Trueperturbation moduli from the complete accumulated projected vectorRoot cause
DynamicalLanczos.prepare_raman(unpolarized=...)accumulated diagonal components for channels 0–3, but an unconditional final preparation call overwrote the result with the last Cartesian component. The real-space and Q-spaceadd=Truepaths also stored the norm of only the latest projected component rather than the accumulated vector.User impact
Unpolarized Raman channels 0–3 now contain the complete rotational-invariant combinations. Previously saved channels 0–3 must be recomputed; channels 4–6 remain reusable. Polarized Raman and IR formulas and scaling are unchanged.
Validation
The strict MkDocs build still reports the repository's existing API-docstring warnings; the standard documentation build succeeds.