Skip to content

Automatically generate release notes when creating new release#8568

Merged
alexey-tikhonov merged 4 commits intoSSSD:masterfrom
pbrezina:relnotes
Apr 14, 2026
Merged

Automatically generate release notes when creating new release#8568
alexey-tikhonov merged 4 commits intoSSSD:masterfrom
pbrezina:relnotes

Conversation

@pbrezina
Copy link
Copy Markdown
Member

This will generate release notes and open a draft pull request against sssd.io

This will make the release process automated, after the workflow is run:

release notes should be reviewed, edited and pushed
release should be un-drafted and published

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive set of scripts to automate the SSSD release notes generation process, including tools for extracting fixed issues, parsing commit tags, and submitting documentation PRs. Several critical issues were identified in the review, including incorrect argument count checks in release.sh, references to non-existent script filenames, unescaped quotes in shell output, and a security risk where sensitive tokens might be leaked into logs due to the use of set -x.

Comment thread scripts/release.sh Outdated
Comment thread scripts/release.sh
Comment thread scripts/generate-full-release-notes.sh Outdated
Comment thread scripts/generate-full-release-notes.sh Outdated
Comment thread scripts/release-notes.sh Outdated
Comment thread scripts/release-notes.sh
@aplopez
Copy link
Copy Markdown
Contributor

aplopez commented Apr 9, 2026

Just one minor remark. When I executed these scripts on my PC I got nothing because my git is configured to default to --pretty=oneline and --abbrev_commit. I guess this will run in a controlled environment so it should be OK. If this assumption is wrong (no controlled environment), then it might be worth explicitly specifying the required parameters for git log, that is --pretty=medium --no-abbrev-commit.
Otherwise, I'm OK with it.

@pbrezina
Copy link
Copy Markdown
Member Author

It's supposed to be run only from GH actions, but it is a good catch nevertheless. Fixed.

Copy link
Copy Markdown
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks.

pbrezina and others added 4 commits April 14, 2026 10:37
Add a bash script to extract and list resolved GitHub issues from git commit
history. The script searches for "Resolves:" references in commit messages
between two git refs and outputs a formatted list of closed issues.

Features:
- Accepts --from <ref> (required) and --to <ref> (defaults to HEAD)
- Supports multiple output formats via --format: plain, rst, md
- Uses gh CLI to fetch issue details (number, title, state)
- Filters to only include closed issues
- Outputs formatted list with issue number, URL, and title

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Generate release notes from commit messages:
./scripts/generate-release-notes.py --from FROM --to TO --version VERSION --format md|rst

Co-Authored-By: Claude <noreply@anthropic.com>
Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
This scripts prepares a release notes for sssd.io.

Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
The release workflow is extended to automatically generate release
notes and open a draft pull request against sssd.io.

Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov alexey-tikhonov merged commit c8257a3 into SSSD:master Apr 14, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants