Fix island-in-lake misclassification #17

Activity

1. jameshgrn

   added this to the v17c-lake-type milestone on Jan 26, 2026
2. jameshgrn

   added

   P1-highHigh priorityHigh priority

   type:bugBug fixBug fix

   region:allAll regionsAll regions

   comp:lake-typeComponent: lake-typeComponent: lake-type

   on Jan 26, 2026
3. jameshgrn

   modified the milestones: v17c-lake-type, v17c-april-2026 on Feb 3, 2026
4. jameshgrn commented on Feb 6, 2026

   

   jameshgrn

   on Feb 6, 2026

   CollaboratorAuthor

   More actions

   Partial Progress

   Lake sandwich correction (issue #19) addressed 1,252 misclassified reaches. Island-in-lake cases are a separate pattern — still needs investigation.
5. jameshgrn

   added

   target:2026-03-04Target completion date 2026-03-04Target completion date 2026-03-04

   on Feb 21, 2026
6. jameshgrn

   self-assigned this

   on Feb 21, 2026
7. jameshgrn

   added a commit that references this issue on Feb 27, 2026

   feat: close multiple v17c threads (#69, #17, #127, #15, #178)

   de115a3
8. jameshgrn commented on Mar 13, 2026

   

   jameshgrn

   on Mar 13, 2026

   CollaboratorAuthor

   More actions

   Reviewer session persistence fixed (2026-03-13)

   The reviewer app had bugs causing reviewed reaches to reappear after Cloud Run restarts — Caroline's skip/fix state wasn't persisting correctly. This has been fixed (commits 1d58732, 6483c84 on reviewer-edits-problem).

   All of Caroline's C001 review work has been recovered and synced across DuckDB + PostgreSQL:

   • 63 active lakeflag fixes in NA
   • 501 skips in NA
   • 9 C004 type/lakeflag fixes in NA

   No review data was lost. See #19 comment for full recovery details.
9. jameshgrn commented on Mar 25, 2026

   

   jameshgrn

   on Mar 25, 2026

   CollaboratorAuthor

   More actions

   Closing — substantially improved in v17c

   Island-in-lake misclassification has been addressed through multiple correction passes:

   • Lake sandwich correction (Update lakeflag for misclassified reaches #19): 1,252 reaches
   • HarP v1.1 lake classification: 7,425 reaches
   • Manual reviewer fixes: 137 reaches (Caroline, NA)

   Remaining island-in-lake cases that don't fall into sandwich/HarP patterns are low count and tracked in the reviewer app for ongoing manual review.
10. jameshgrn

    closed this as completedon Mar 25, 2026