🐛 Fix container deletion stuck on large journal entry count#238
Merged
Conversation
Override Container.delete() to remove journal entries via _raw_delete before the Django cascade, bypassing per-row post_delete signals (ObjectChange writes) that made deletion O(n) slow for containers with thousands of journal entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…unts
Override _get_dependent_objects to skip JournalEntry from the Django
Collector (avoids fetching all rows) and replace it with a lazy COUNT
proxy that answers len() with a single indexed COUNT(*) query and yields
nothing on iteration. The accordion header shows the correct count while
the page loads instantly regardless of journal entry volume.
Also add select_related("host", "image") on the queryset to avoid N+1
queries when rendering the confirmation page.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lvenier
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override Container.delete() to remove journal entries via _raw_delete before the Django cascade, bypassing per-row post_delete signals (ObjectChange writes) that made deletion O(n) slow for containers with thousands of journal entries.