Skip to content

Hide register link when registration is disabled#1073

Merged
7w1 merged 2 commits into
SableClient:devfrom
eleboucher:fix/hide-register-when-disabled
Jul 13, 2026
Merged

Hide register link when registration is disabled#1073
7w1 merged 2 commits into
SableClient:devfrom
eleboucher:fix/hide-register-when-disabled

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

When a homeserver has registration disabled, the Login page still showed a "Do not have an account? Register" prompt that led to a dead-end Register page (which only renders "Registration has been disabled on this homeserver."). This hides that prompt when registration is genuinely unavailable, the server reports registration disabled (403 M_FORBIDDEN) and offers no SSO flow to register through. Password and SSO login are unaffected, and the Register page keeps its message as a fallback for direct navigation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

code completion and 2nd review

@eleboucher eleboucher marked this pull request as ready for review July 13, 2026 18:01
@eleboucher eleboucher requested review from 7w1 and hazre as code owners July 13, 2026 18:01

@7w1 7w1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just add a changeset please

@eleboucher eleboucher requested a review from 7w1 July 13, 2026 18:14
@7w1 7w1 added this pull request to the merge queue Jul 13, 2026
Merged via the queue into SableClient:dev with commit e4f194b Jul 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants