Skip to content

feat(mobile): render global modals as full-screen pages#1150

Merged
7w1 merged 2 commits into
SableClient:devfrom
eleboucher:feat/mobile-full-screen-pages
Jul 20, 2026
Merged

feat(mobile): render global modals as full-screen pages#1150
7w1 merged 2 commits into
SableClient:devfrom
eleboucher:feat/mobile-full-screen-pages

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Search, create room, create space, and bug report open as full-screen pages on mobile via useOpen*Modal hooks checking useScreenSizeContext. Desktop modal flow unchanged.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 20, 2026 08:12
@eleboucher
eleboucher force-pushed the feat/mobile-full-screen-pages branch 5 times, most recently from a3e9be0 to 19d0c0b Compare July 20, 2026 17:00
@7w1

7w1 commented Jul 20, 2026

Copy link
Copy Markdown
Member

conflicts :(

@eleboucher
eleboucher force-pushed the feat/mobile-full-screen-pages branch 2 times, most recently from f936bdd to a359636 Compare July 20, 2026 21:27
eleboucher and others added 2 commits July 20, 2026 16:38
Search, create room, create space, and bug report open as full-screen
pages on mobile via useOpen*Modal hooks checking useScreenSizeContext.
Desktop modal flow unchanged.

Adds full-screen room/space settings with shared section layout and
swipe-back navigation.

Adds tauri-plugin-sharekit (v0.4.0-rc.5) for iOS/Android system share
sheet, with a shareText() util that falls back to Web Share API then
clipboard. Wired into ShareChip, Space menu, SpaceTabs menu.

Syncs Cargo.lock with the new sharekit dependency and relaxes the
edge-to-edge inset contract test to match the wired plugin via
.plugin(tauri_plugin_edge_to_edge::init()) so chaining sharekit onto
the same mobile builder no longer breaks the test.
@7w1
7w1 force-pushed the feat/mobile-full-screen-pages branch from a359636 to 76a6874 Compare July 20, 2026 21:43
@7w1
7w1 added this pull request to the merge queue Jul 20, 2026
Merged via the queue into SableClient:dev with commit 8ee0b2a Jul 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants