Skip to content

Fix ios safe zone problems #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 2 commits into from
Jul 20, 2026
Merged

Fix ios safe zone problems #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25209ed
fix(pwa): make ios safe area viewport height stateless
7w1 Jul 20, 2026
a6dbee0
formatting
7w1 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/app/styles/edgeToEdgeInsets.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,11 @@ describe('android edge-to-edge inset contract', () => {
expect(indexTsx).toContain('installIosPwaViewportHeight();');
expect(iosPwaViewport).toContain("window.matchMedia('(display-mode: standalone)').matches");
expect(iosPwaViewport).toContain('const MIN_KEYBOARD_HEIGHT = 100');
expect(iosPwaViewport).toContain('const keyboardOpen = fullHeight - visibleHeight');
expect(iosPwaViewport).toContain('const height = keyboardOpen ? visibleBottom : fullHeight');
expect(iosPwaViewport).toContain('isEditableFocused()');
expect(iosPwaViewport).toContain('screenHeight - visibleHeight > MIN_KEYBOARD_HEIGHT');
expect(iosPwaViewport).toContain('window.setTimeout(updateHeight, 350)');
expect(iosPwaViewport).not.toContain('fullHeight');
expect(iosPwaViewport).not.toContain('viewportWidth');
});

it('removes the scattered safe-area css consumers', () => {
Expand Down
26 changes: 16 additions & 10 deletions src/app/utils/iosPwaViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,35 @@ const isStandaloneIosPwa = (): boolean =>
window.matchMedia('(display-mode: standalone)').matches &&
CSS.supports('-webkit-touch-callout: none');

const isEditableFocused = (): boolean => {
const el = document.activeElement as HTMLElement | null;
if (!el) return false;
return el.tagName === 'INPUT' || el.tagName === 'TEXTAREA' || el.isContentEditable;
};

const fullScreenHeight = (): number => {
const { width, height } = window.screen;
return window.matchMedia('(orientation: portrait)').matches
? Math.max(width, height)
: Math.min(width, height);
};

export function installIosPwaViewportHeight(): void {
if (!isStandaloneIosPwa()) return;

let frame = 0;
let settleTimer = 0;
let fullHeight = 0;
let viewportWidth = window.innerWidth;

const updateHeight = () => {
frame = 0;
const viewport = window.visualViewport;
const visibleHeight = viewport?.height ?? window.innerHeight;
const visibleBottom = visibleHeight + (viewport?.offsetTop ?? 0);

if (window.innerWidth !== viewportWidth) {
viewportWidth = window.innerWidth;
fullHeight = visibleBottom;
}

const keyboardOpen = fullHeight - visibleHeight > MIN_KEYBOARD_HEIGHT;
if (!keyboardOpen) fullHeight = Math.max(fullHeight, visibleBottom);
const screenHeight = fullScreenHeight();
const keyboardOpen = isEditableFocused() && screenHeight - visibleHeight > MIN_KEYBOARD_HEIGHT;
const height = keyboardOpen ? visibleBottom : screenHeight;

const height = keyboardOpen ? visibleBottom : fullHeight;
document.documentElement.style.setProperty(IOS_PWA_VIEWPORT_HEIGHT, `${Math.round(height)}px`);
};

Expand Down
Loading