Fix no sleeping#1
Open
jschiff wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the "no sleeping" behavior by updating the conditions in the FixedUpdate method of BetterRigidbody.cs.
- Updated the condition in FixedUpdate to only apply exempted velocity changes when the value is nonzero and the rigidbody is not kinematic.
- Moved the reset of _exemptedVelocityChange into the conditional block.
Comment on lines
+63
to
64
| _exemptedVelocityChange = Vector3.zero; | ||
| } |
There was a problem hiding this comment.
The current condition may prevent _exemptedVelocityChange from being reset when _rb.isKinematic is true, potentially leaving stale data for future frames. Consider resetting _exemptedVelocityChange outside the conditional block to ensure it is always cleared.
Suggested change
| _exemptedVelocityChange = Vector3.zero; | |
| } | |
| } | |
| _exemptedVelocityChange = Vector3.zero; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.