Open
Conversation
Contributor
Author
Code reviewFound 2 issues:
synapsePythonClient/synapseclient/models/services/manifest.py Lines 59 to 61 in 9a15057 synapsePythonClient/docs/explanations/manifest_csv.md Lines 46 to 48 in 9a15057
synapsePythonClient/synapseclient/models/services/manifest.py Lines 375 to 377 in 9a15057 synapsePythonClient/synapseutils/sync.py Lines 56 to 57 in 9a15057 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The
syncToSynapsefunction doesn't fit the new OOP model paradigm.Solution:
sync_to_synapsemethod was added to theStorableContainerclasssyncToSynapsewas deprecatedTesting:
sync_to_synapsemethod