[tools/onnx-subgraph] add config.json for onnx model splitting#14852
Merged
Conversation
config.json for onnx model splitting, it will be used in future PRs ONE-DCO-1.0-Signed-off-by: Youxin Chen <yx113.chen@samsung.com>
seanshpark
reviewed
Mar 16, 2025
Comment on lines
+2
to
+4
| "NPU_supported_ops": ["Conv", "Reshape", "Transpose", "Add", "ReduceMean", "Sub", "Div", "Mul", "Sigmoid","MatMul"], | ||
| "CPU_supported_ops": ["Sub", "Pow", "ReduceMean", "Add", "Sqrt", "Div","Transpose", "Gather", "MatMul", "Mul", "Softmax", "Erf", "Gemm", "Conv", "Reshape", | ||
| "Sin", "Where", "ConstantOfShape", "Cast", "Sigmoid", "Cos", "Expand", "Slice", "Unsqueeze"], |
Contributor
There was a problem hiding this comment.
it would be nice if you could split lines so that text comes inside 100 cols.
seanshpark
reviewed
Mar 16, 2025
Comment on lines
+6
to
+7
| {"name":"Conv","CPU_time": 0.1, "NPU_time": 0.05}, | ||
| {"name":"Mul", "CPU_time": 0.15, "NPU_time": 0.07} |
Contributor
There was a problem hiding this comment.
As I understand, if the performance data is changed by targets, we should update these values.
update to these won't be good with source code management.
So, I suggest not to put these in here but to explain in the README file to add in performance_data item.
And/Or you can provide something like config.sample.json file with explanation in README so that users can follow by an example.
Contributor
Author
There was a problem hiding this comment.
yes, I agree with you, I add it to examples path, and will add description for this config in readme later, thank you
seanshpark
reviewed
Mar 16, 2025
| {"name":"Conv","CPU_time": 0.1, "NPU_time": 0.05}, | ||
| {"name":"Mul", "CPU_time": 0.15, "NPU_time": 0.07} | ||
| ], | ||
| "hardware_limits": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: #14534
historical full changes PR: #14613
config.json for onnx model splitting, it will be used in future PRs
ONE-DCO-1.0-Signed-off-by: Youxin Chen yx113.chen@samsung.com