Skip to content

[luci] Add additional negative unit test for Reshape#14859

Merged
seanshpark merged 2 commits into
Samsung:masterfrom
mbencer:mbencer/ReshapeAdditionalUnitTest
Mar 24, 2025
Merged

[luci] Add additional negative unit test for Reshape#14859
seanshpark merged 2 commits into
Samsung:masterfrom
mbencer:mbencer/ReshapeAdditionalUnitTest

Conversation

@mbencer

@mbencer mbencer commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com

This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
@seanshpark

Copy link
Copy Markdown
Contributor

Plz follow #14844 (comment) for this too

jinevening
jinevening previously approved these changes Mar 21, 2025

@jinevening jinevening left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanshpark
seanshpark previously approved these changes Mar 21, 2025

@seanshpark seanshpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again, doesn't need recipe for testing.
LGTM

@seanshpark

Copy link
Copy Markdown
Contributor

plz resolve conflict

@mbencer mbencer dismissed stale reviews from seanshpark and jinevening via c1334a5 March 21, 2025 07:27
@seanshpark seanshpark merged commit de81bb4 into Samsung:master Mar 24, 2025
@mbencer mbencer deleted the mbencer/ReshapeAdditionalUnitTest branch May 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants