temurin-jre: correct extract_dir in autoupdate#602
Conversation
WalkthroughTwo Java package configuration files updated to remove the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. temurin-jre
|
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with temurin-jre
temurin-lts-jre
|
|
All changes look good. Wait for review from human collaborators. temurin-jre
temurin-lts-jre
|
|
All changes look good. Wait for review from human collaborators. temurin-jre
temurin-lts-jre
|
The suffix IS correct for Temurin JRE ZIPs. All specific-version JRE manifests (temurin26-jre.json, temurin25-jre.json, etc.) consistently use the suffix. The PR's removal of it was based on an incorrect assumption about the ZIP's extracted directory name.
|
Closing — the suffix was correct all along. Investigation findings: All specific-version JRE manifests (temurin26-jre.json, temurin25-jre.json, etc.) on master consistently use the suffix for both The version bump that occurred upstream while this PR was waiting review (from 26+35 → 26.0.1+8) already resolved the stale-version issue. The convention was correctly applied in the upstream version bump. The PR branch now matches upstream/master exactly — there are zero effective changes remaining. |
Closes #552
Summary
Fixes the extraction directory mismatch bug that causes temurin-jre and temurin-lts-jre updates to fail.
Problem
The autoupdate formula uses
$matchTag-jrewhich adds a-jresuffix to the expected extraction directory. However, the actual extracted directory from the Temurin JRE ZIP files is justjdk-{tag}WITHOUT the-jresuffix.This caused issue #552 where updating temurin-jre from 24.0.1-9 to 24.0.2-12 failed with "Could not find jdk-24.0.2+12-jre".
Fix
$matchTag-jreto$matchTag-jresuffix to base tag; also updated to latest LTS version 25.0.3-9Validation
All checks pass in both manifests.