Skip to content

name: transient should prefix with t_#64

Open
thelostone-mc wants to merge 5 commits into
mainfrom
transient
Open

name: transient should prefix with t_#64
thelostone-mc wants to merge 5 commits into
mainfrom
transient

Conversation

@thelostone-mc

@thelostone-mc thelostone-mc commented Feb 27, 2026

Copy link
Copy Markdown
Contributor
image

@thelostone-mc thelostone-mc force-pushed the transient branch 4 times, most recently from 5ae8901 to ea6c274 Compare February 27, 2026 07:39
@thelostone-mc thelostone-mc marked this pull request as ready for review March 2, 2026 05:51

@apbendi apbendi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question @garyghayrat

@@ -23,13 +23,11 @@ pub fn validate(parsed: &Parsed) -> Vec<InvalidItem> {
invalid_items.push(invalid_item);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arbitrary comment location

Is there a way to turn the check off for a given line, file etc... In other words, do we have an escape hatch if the user has to name a transient var "incorrectly" for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants