fix(ci): annotate per-board snippets with Pi Imager devices tags#2923
Open
vpetersson wants to merge 2 commits into
Open
fix(ci): annotate per-board snippets with Pi Imager devices tags#2923vpetersson wants to merge 2 commits into
vpetersson wants to merge 2 commits into
Conversation
Pi Imager filters the OS list against the user-selected device. The Pi 5 entry in the upstream root JSON uses `matching_type: exclusive`, so an image lacking a `devices` array is silently hidden when a user picks Pi 5 in the device picker. Raspberry Pi has signalled (Nov 2023 Tom Dewey email) that the same exclusive filter will roll out to older boards. Our per-board JSON snippets currently emit no `devices` field — meaning fresh Anthias builds wouldn't surface in Pi Imager on Pi 5 even if the upstream master list pointed at our subitems_url. - Map BOARD slug → device tags in the workflow's package step (pi2 → pi2-32bit, pi3 → pi3-64bit, pi4-64 → pi4-64bit, pi5 → pi5-64bit, x86 → []). - Extend REQUIRED_FIELDS in build_pi_imager_json.py so the contract is documented and the existing required-fields test enforces it. - Update test fixtures + add a per-board devices-preservation test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Anthias pi3 image is 32-bit armhf (target_platform `linux/arm/v7` in tools/image_builder/utils.py, with libraspberrypi0 linked via the Raspbian legacy userland — see image_builder/__main__.py which calls out pi2/pi3 as the 32-bit boards). The balena image type is `raspberrypi3` (32-bit), not `raspberrypi3-64`. Tagging this image as `pi3-64bit` misdescribes what's in the .img.zst and would hide it from Pi 3 users if/when Pi Imager flips Pi 3 to `matching_type: exclusive` or adds a bitness filter. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Pi Imager filters the OS list against the user-selected device. The Pi 5 entry in the upstream root JSON uses
matching_type: exclusive— an image lacking adevicesarray is silently hidden when a user picks Pi 5 in the device picker. Raspberry Pi has signalled (Tom Dewey email, Nov 2023) that the same exclusive filter will roll out to older boards.Our per-board JSON snippets currently emit no
devicesfield, so even after we switch the upstream Anthias entry tosubitems_url: https://anthias.screenly.io/rpi-imager.json, our Pi 5 build wouldn't surface to users.Description
pi2→["pi2-32bit"]pi3→["pi3-64bit"]pi4-64→["pi4-64bit"]pi5→["pi5-64bit"]x86→[](not a Pi Imager target — empty array keeps the snippet schema-valid)devicestoREQUIRED_FIELDSinbuild_pi_imager_json.pyso the contract is documented and the existing required-fields test enforces it.make_image_metadatato includedevices, and add a per-board parametrized test that the field round-trips throughretrieve_and_patch_jsonunmodified.Tags taken from the canonical
imager.devices[*].tagsinhttps://downloads.raspberrypi.org/os_list_imagingutility_v4.json.Checklist