Skip to content

fix(upgrade): remove legacy srly-ose-redis container#2936

Merged
vpetersson merged 1 commit into
masterfrom
worktree-moonlit-wiggling-feigenbaum
May 21, 2026
Merged

fix(upgrade): remove legacy srly-ose-redis container#2936
vpetersson merged 1 commit into
masterfrom
worktree-moonlit-wiggling-feigenbaum

Conversation

@vpetersson
Copy link
Copy Markdown
Contributor

Issues Fixed

Forum report: Upgrade fails during 'Initialize / Upgrade Docker Containers' — three Pi 4B / Bookworm Lite units fail upgrade with:

Error response from daemon: failed to set up container networking: driver failed programming external connectivity on endpoint anthias-redis-1 [...]: Bind for 127.0.0.1:6379 failed: port is already allocated

Description

bin/upgrade_containers.sh already sweeps legacy containers no longer in the compose file (srly-ose-{nginx,websocket,wifi-connect,celery}, etc.) but not srly-ose-redis. On pre-rebrand Screenly OSE installs that container stays running and holds 127.0.0.1:6379, so the new anthias-redis can't claim the port and compose up fails.

Adds srly-ose-redis to the docker rm -f cleanup list. The compose stack will recreate Redis under the new name; redis-data is on a named volume so no data is lost.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

- pre-rebrand Redis container still bound to 127.0.0.1:6379 prevents
  anthias-redis from claiming the port on upgrade
- ref: forums.screenly.io/t/6688

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vpetersson vpetersson requested a review from a team as a code owner May 21, 2026 06:07
@vpetersson vpetersson self-assigned this May 21, 2026
@sonarqubecloud
Copy link
Copy Markdown

@vpetersson vpetersson merged commit c277914 into master May 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant