fix(doctor): derive orphan stores from registry reconstruction#439
Conversation
|
2336585 to
46bffbe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 233658571d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !diff.issues.is_empty() { | ||
| return diff; |
There was a problem hiding this comment.
Continue diffing after unrelated reconstruction conflicts
In profiles with more than one eligible store manifest, a single conflicting plan (for example an existing registry row for the same root owned by a different project) makes the preflight return an issue here and skips registry_plan_has_missing_rows for every other plan. doctor/health then report zero orphan reconstructable manifests even when other manifests simply have missing registry rows, so one bad manifest hides the actionable repairs this check is meant to surface. Keep the issue but still compute missing rows for non-conflicting plans, or preflight per plan.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid. Fixed with per-plan preflight plus a conflict+missing regression in #440.
Summary
Verification
cargo test orphan_reporting_uses_complete_registry_rows_not_token_accounting --libcargo check --workspace --all-targets --lockedcargo clippy --workspace --all-targets --locked -- -D warningscargo fmt --checktracedecay doctor: DB integrity ok; false orphan warning absenttracedecay tool health --details true: 7107; exact writable branch store; no drift/storage warnings