Skip to content

[dotnet] run format against slnx instead of looping csproj #17483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 6 commits into from
May 18, 2026
+22 −14
Merged

[dotnet] run format against slnx instead of looping csproj #17483

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4015680
[dotnet] run format against slnx instead of looping csproj
titusfortner May 16, 2026
34a5b8c
fix order of execution
titusfortner May 16, 2026
8df75a3
apply fix from c471ccabf9
titusfortner May 16, 2026
99695da
[dotnet] temporary diagnostic verbosity for windows lint debug
titusfortner May 17, 2026
3337555
AllowMissingPrunePackageData
titusfortner May 17, 2026
09a78e4
remove debugging
titusfortner May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions dotnet/private/dotnet_format.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,20 @@ DOTNET="$RUNFILES_DIR/{dotnet}"
# Find the workspace root
WORKSPACE_ROOT="${{BUILD_WORKSPACE_DIRECTORY:-$RUNFILES_DIR/_main}}"
DOTNET_DIR="$WORKSPACE_ROOT/dotnet"
SOLUTION="$DOTNET_DIR/Selenium.slnx"

cd "$DOTNET_DIR"

echo "Running dotnet format $@ on all projects..."
find "$DOTNET_DIR/src" "$DOTNET_DIR/test" -name "*.csproj" 2>/dev/null | while read -r proj; do
echo " Formatting $proj..."
"$DOTNET" format "$@" "$proj" || exit 1
done || exit 1
# Bazel-bundled SDK ref packs lack prune metadata; opt out of NETSDK1226.
export AllowMissingPrunePackageData=true

if [[ ! -f "$SOLUTION" ]]; then
echo "ERROR: Could not find $SOLUTION" >&2
exit 1
fi

echo "Running dotnet format $@ on Selenium.slnx..."
"$DOTNET" format "$@" "$SOLUTION" || exit 1

echo "Done."
""".format(
Expand All @@ -78,7 +84,7 @@ def _create_windows_script(ctx, dotnet):
script_content = """@echo off
setlocal

set RUNFILES_DIR=%~dp0%~n0.runfiles
set RUNFILES_DIR=%~dp0%~nx0.runfiles
set DOTNET=%RUNFILES_DIR%\\{dotnet_path}

if defined BUILD_WORKSPACE_DIRECTORY (
Expand All @@ -87,19 +93,21 @@ if defined BUILD_WORKSPACE_DIRECTORY (
set WORKSPACE_ROOT=%RUNFILES_DIR%\\_main
)
set DOTNET_DIR=%WORKSPACE_ROOT%\\dotnet
set SOLUTION=%DOTNET_DIR%\\Selenium.slnx

cd /d "%DOTNET_DIR%"

echo Running dotnet format %* on all projects...
for /r "%DOTNET_DIR%\\src" %%p in (*.csproj) do (
echo Formatting %%p...
"%DOTNET%" format %* "%%p" || exit /b 1
)
for /r "%DOTNET_DIR%\\test" %%p in (*.csproj) do (
echo Formatting %%p...
"%DOTNET%" format %* "%%p" || exit /b 1
rem Bazel-bundled SDK ref packs lack prune metadata; opt out of NETSDK1226.
set AllowMissingPrunePackageData=true

if not exist "%SOLUTION%" (
echo ERROR: Could not find %SOLUTION% 1>&2
exit /b 1
)

echo Running dotnet format %* on Selenium.slnx...
"%DOTNET%" format %* "%SOLUTION%" || exit /b 1

echo Done.
""".format(
dotnet_path = dotnet_runfiles_path,
Expand Down
Loading