Require PHP 8.4, replace Psalm with PHPStan, upgrade Valinor to 2.x, remove PSL#24
Merged
Merged
Conversation
…remove PSL - Require PHP >= 8.4 and trim symfony/options-resolver to ^6.4 || ^7.0 || ^8.0 - Replace Psalm with PHPStan (level max) via setono/code-quality-pack ^3.4 - Upgrade cuyz/valinor to ^2.0 and let it handle the top-level JSON shape validation previously done with azjezz/psl - Migrate test suite to PHPUnit 11 (attributes, static data providers) - Modernize rector.php for Rector 2.x with PHP 8.4 + PHPUnit sets - Update CI matrices to PHP 8.4 and 8.5
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.x #24 +/- ##
============================================
- Coverage 82.41% 81.91% -0.51%
- Complexity 83 86 +3
============================================
Files 29 29
Lines 290 293 +3
============================================
+ Hits 239 240 +1
- Misses 51 53 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symfony/options-resolvertrimmed to^6.4 || ^7.0 || ^8.0.setono/code-quality-pack ^3.4brings PHPStan 2.x with strict rules, PHPUnit and webmozart-assert extensions. Newphpstan.dist.neonat levelmax(no baseline), includes Valinor's bundled PHPStan extension so the array-shape mapping inParserstays fully typed. All@psalm-*annotations converted to@phpstan-*equivalents or made redundant by inline narrowing.Messages::flattenFromNode($e->node())to$e->messages(); the sharedMapperBuildernow also setsallowPermissiveTypes()since Valinor 2's strict mode otherwise rejects themixedblock data.Parser::parse()is now done by Valinor mapping to an array shape.InvalidDataException::__construct()consequently acceptsCuyZ\Valinor\Mapper\MappingErrorinstead of PSL'sAssertException.public static.new X()->method()chaining, explicit nullable params, etc.).Behavior notes
shape()rejected them) — more lenient, forward-compatible with new EditorJS exports.phpunit/phpunitis intentionally not a direct dev dependency (provided by the pack); the shadow-dependency finding is ignored incomposer-dependency-analyser.php.Test plan
vendor/bin/phpunitgreen on highest and lowest deps (46 tests)vendor/bin/phpstan0 errors at level max on highest and lowest depscomposer check-style,vendor/bin/rector --dry-run,vendor/bin/composer-dependency-analyser,composer validate --strict,composer normalize --dry-runall clean