feat: add async http client using httpx.AsyncClient#27
Open
fathiaoyinloye wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8
Description
Implemented an async HTTP client using
httpx.AsyncClientwhile maintaining compatibility with the existing sync client interface.Changes Made
_AsyncHTTPClientinsrc/shade/http.pyhttpx.AsyncClientaclose()_build_url,_build_headers,_build_request) to reduce duplication between sync and async clientsAsyncHTTPClientinterface for backwards compatibilityhttpxto development dependenciesThis change enables the SDK to be used in async frameworks such as FastAPI, Starlette, and Django async views while preserving the existing request and response behavior.
Fixes #
Type of change
How Has This Been Tested?
Ran
pytest -qResults: 30 passed, 3 skipped
Verified async requests return the same JSON-decoded response structure as the sync client
Verified
await client.aclose()properly closes the async clientConfirmed sync and async clients share URL-building and header-generation logic through common helper functions
Pytest test suite (
pytest -q)Manual verification of async request flow
Checklist: