test(errors): add RateLimitError coverage (Closes #19)#28
Merged
codebestia merged 1 commit intoJun 26, 2026
Merged
Conversation
Extend the error test suite to verify RateLimitError inherits from ShadeError, exposes retry_after, and is exported from the package root. Closes ShadeProtocol#19
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ChangesRateLimitError test coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
codebestia
approved these changes
Jun 26, 2026
codebestia
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Thank you for your contribution.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19
RateLimitErrorwas already implemented onmainvia PR #24 (errors.py,http.py, andtests/test_rate_limit.py). This PR adds complementary coverage intests/test_errors.pyto verify:RateLimitErrorinherits fromShadeErrorretry_afteris set from theRetry-Afterheader value (orNonewhen absent)RateLimitErroris exported from the package rootAcceptance criteria verification
RateLimitErrorsrc/shade/http.py(_raise_for_status)error.retry_afterreflectsRetry-Afterheadertests/test_rate_limit.pyretry_afterisNonewhen header absenttests/test_rate_limit.py,tests/test_errors.pyTest plan
poetry run pytest -v— 35/35 passedSummary by CodeRabbit
Bug Fixes
Tests