Skip to content

[Env] Adastra AdaptiveCPP environment#1869

Open
y-lapeyre wants to merge 13 commits into
Shamrock-code:mainfrom
y-lapeyre:env/adastra_acpp
Open

[Env] Adastra AdaptiveCPP environment#1869
y-lapeyre wants to merge 13 commits into
Shamrock-code:mainfrom
y-lapeyre:env/adastra_acpp

Conversation

@y-lapeyre

@y-lapeyre y-lapeyre commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

This environment works on Adastra without the weird compiler bug of LLVM.

Left to do:

  • edit the example batch

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Thanks @y-lapeyre for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new environment configuration for the Adastra system using AdaptiveCpp with ROCm/LLVM, consisting of a build script, an example batch submission script, and a Python setup script. The review feedback highlights several opportunities for improvement, including correcting the path for the ldd command, handling unmatched glob patterns safely, quoting shell variables to prevent word splitting, using "$@" instead of $* to preserve argument boundaries, and updating the PATH variable in the Python setup script to match the actual directory structure.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread env/machine/adastra/mi250/acpp-rocm/exemple_batch.sh Outdated
Comment thread env/machine/adastra/mi250/acpp-rocm/env_built_acpp.sh
Comment thread env/machine/adastra/mi250/acpp-rocm/env_built_acpp.sh
Comment thread env/machine/adastra/mi250/acpp-rocm/env_built_acpp.sh
Comment thread env/machine/adastra/mi250/acpp-rocm/env_built_acpp.sh
Comment thread env/machine/adastra/mi250/acpp-rocm/exemple_batch.sh Outdated
Comment thread env/machine/adastra/mi250/acpp-rocm/exemple_batch.sh Outdated
Comment thread env/machine/adastra/mi250/acpp-rocm/setup-env.py Outdated
@y-lapeyre y-lapeyre changed the title [Env] Adastra AdapticeCPP [Env] Adastra AdaptiveCPP Jun 7, 2026
@y-lapeyre y-lapeyre changed the title [Env] Adastra AdaptiveCPP [Env] Adastra AdaptiveCPP environment Jun 7, 2026
@y-lapeyre y-lapeyre requested review from aserhani and tdavidcl June 8, 2026 09:19
Comment on lines +12 to +34
module purge
source /opt/cray/pe/cpe/24.07/restore_lmod_system_defaults.sh
# A CrayPE environment version
module load cpe/24.11
# An architecture
module load craype-accel-amd-gfx90a craype-x86-trento
# A compiler to target the architecture
module load PrgEnv-cray
# Some architecture related libraries and tools
module load amd-mixed/6.4.3

module list

export MPICH_GPU_SUPPORT_ENABLED=1
export SYCL_DEVICE_ALLOCATOR=aligned
# export OMP_<ICV=XXX>
WORKDIR=<path-to-Shamrock-build-directory>

. /opt/cray/pe/cpe/24.11/restore_lmod_system_defaults.sh

export SHAM_MAX_ALLOC_SIZE=4294967296

. ./activate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are already providing the module loads in the activate script. It should work if you remove the one here i'd assume

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 16bfd2c
Commiter email is timothee.davidcleris@proton.me
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 7862 → 7862 (0.0%)

Detailed changes :

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants