[Env] Adastra AdaptiveCPP environment#1869
Conversation
|
Thanks @y-lapeyre for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
There was a problem hiding this comment.
Code Review
This pull request adds a new environment configuration for the Adastra system using AdaptiveCpp with ROCm/LLVM, consisting of a build script, an example batch submission script, and a Python setup script. The review feedback highlights several opportunities for improvement, including correcting the path for the ldd command, handling unmatched glob patterns safely, quoting shell variables to prevent word splitting, using "$@" instead of $* to preserve argument boundaries, and updating the PATH variable in the Python setup script to match the actual directory structure.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| module purge | ||
| source /opt/cray/pe/cpe/24.07/restore_lmod_system_defaults.sh | ||
| # A CrayPE environment version | ||
| module load cpe/24.11 | ||
| # An architecture | ||
| module load craype-accel-amd-gfx90a craype-x86-trento | ||
| # A compiler to target the architecture | ||
| module load PrgEnv-cray | ||
| # Some architecture related libraries and tools | ||
| module load amd-mixed/6.4.3 | ||
|
|
||
| module list | ||
|
|
||
| export MPICH_GPU_SUPPORT_ENABLED=1 | ||
| export SYCL_DEVICE_ALLOCATOR=aligned | ||
| # export OMP_<ICV=XXX> | ||
| WORKDIR=<path-to-Shamrock-build-directory> | ||
|
|
||
| . /opt/cray/pe/cpe/24.11/restore_lmod_system_defaults.sh | ||
|
|
||
| export SHAM_MAX_ALLOC_SIZE=4294967296 | ||
|
|
||
| . ./activate |
There was a problem hiding this comment.
You are already providing the module loads in the activate script. It should work if you remove the one here i'd assume
Workflow reportworkflow report corresponding to commit 16bfd2c Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This environment works on Adastra without the weird compiler bug of LLVM.
Left to do: