Move Android dev commands under root dev.yml#35
Open
kyle-schellen wants to merge 1 commit into
Open
Conversation
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
dbc5438 to
6e8f971
Compare
6e8f971 to
f73c836
Compare
kiftio
reviewed
May 11, 2026
f73c836 to
7d3dd73
Compare
11 tasks
Contributor
|
I think this is shaping up nicely! This feedback ranges across the stack, so dropping it here in a single dump, and the first point is repeated from comment thread below, however don't consider this feedback as blocking, we should go forwards with merging as is so everyone can benefit from it this week. Improvements can be stacked on top? I think the main improvement will be conformity and parity
|
68173bf to
e0453ab
Compare
Contributor
Juanita-Dash
left a comment
There was a problem hiding this comment.
Review assisted by pair-review
e0453ab to
ee59056
Compare
ee59056 to
84d8099
Compare
kieran-osgood-shopify
approved these changes
May 13, 2026
kiftio
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Move android/dev.yml into namespaced commands at the repo root so
dev upanddev android <cmd>work from the monorepo root. Refs #908. Swift to follow upstack.How to test
From the repo root:
dev upcompletes without errordev android buildruns the Android library builddev android testruns the Android test suitedev android lintruns detekt + Android lintdev android stylestill works as a legacy alias forlintdev android fixruns detekt autocorrectiondev android api checkpasses against the committed baselinedev android checkruns license headers + detekt +lintReleaseEach command should match the behavior of the corresponding command under the old Android
dev.yml.Before you merge
Important
swift/README.mdand/orandroid/README.md)Releasing a new Swift version?
swift/ShopifyCheckoutKit.podspecswift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftswift/CHANGELOG.mdswift/README.md(major version only)Releasing a new Android version?
versionNameinandroid/lib/build.gradleandroid/CHANGELOG.mdandroid/README.mdTip
See the Contributing documentation for the full release process per platform.foll