Prevent adding end token on endless methods#4042
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
st0012
reviewed
Mar 31, 2026
Member
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Does it add an end for this? (it shouldn't)
def hello = puts(
"hello"
)
vinistock
force-pushed
the
03-31-prevent_adding_end_token_on_endless_methods
branch
from
6ad2a91 to
f8d31ee
Compare
Member
Author
|
That scenario already worked, but I added it as a test case. |
st0012
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Working on #4041, I realized that we were incorrectly adding the
endtoken when breaking the line on endless method definitions. This PR prevents that from happening.Implementation
Just added another check to verify that the
defis not followed by an endless method definition.Automated Tests
Added a test for an invalid syntax case and for a valid one.