Hide SaveBar on unmount synchronously#563
Open
afurm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaveBarduring unmount with an isomorphic layout effect.@shopify/app-bridge-react.Why
React passive effect cleanup can run after the
ui-save-barelement has been detached. In that case, the App Bridge SaveBar can remain visible after the React wrapper unmounts, leaving navigation blocked and stale Save/Discard handlers visible. Running the unmount cleanup in a browser layout effect keeps the element available while callinghide(), while still usinguseEffecton the server to avoid SSR layout-effect warnings.Fixes #532.
Validation
mise exec node@24.13.1 -- pnpm install --frozen-lockfilemise exec node@24.13.1 -- pnpm format:checkmise exec node@24.13.1 -- pnpm buildmise exec node@24.13.1 -- pnpm lintmise exec node@24.13.1 -- pnpm type-checkmise exec node@24.13.1 -- pnpm test