Release v3.11.0#420
Merged
Merged
Conversation
pedro-stanaka
approved these changes
Apr 2, 2026
pedro-stanaka
left a comment
pedro-stanaka
left a comment
Contributor
There was a problem hiding this comment.
Between these two things, I believe we do not need a major version bump.
Agreed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ What
Release
CompiledMetric.metric_nameand the developer experience fix of disallowingCompiledMetric.defineoutside of a subclass.🤔 Why
The
metric_namemethod is a net-new feature so warrants a minor version.Caution
The disallowing of the
CompiledMetric.definebeing called on the top-level class is technically a breaking change, but was a broken experience as soon as you calleddefineon a second metric of the same type so it's unlikely anyone relied on it.Additionally, the change of error type for not calling
defineis a breaking change, but it's not one that anyone would rescue since the metric wouldn't work and would continually raise.Between these two things, I believe we do not need a major version bump.
Checklist