Add targeted check --junitxml test coverage for XML output and failure reporting#94
Draft
Copilot wants to merge 6 commits into
Draft
Add targeted check --junitxml test coverage for XML output and failure reporting#94Copilot wants to merge 6 commits into
check --junitxml test coverage for XML output and failure reporting#94Copilot wants to merge 6 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code according to review comment
Add targeted Jun 15, 2026
check --junitxml test coverage for XML output and failure reporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review feedback requested explicit coverage for the new
--junitxmlmode in thecheckCLI path. This update adds focused tests intests/test_check.pyto assert report generation and failure serialization for invalid rules.Test coverage added
test_check_junitxml_created_and_well_formedto verify:testsuiteortestsuites)test_check_junitxml_reports_failures_for_invalid_rulesto verify invalid rules emit<failure>entries.Branch-safe guard for option availability
checkdoes not expose ajunitxmlparameter (keeps tests scoped to the reviewed feature without introducing unrelated failures in branches lacking the option).