Remove unused quadrature modifiers from the Niederer CEP benchmark - #589
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
I believe these changes are simple and can be merged today. We have essentially just removed the quadrature parameters from the xml input files and renamed the data files to remove the "quadrature" from the file names since these tests do not actually cover quadrature options. @ktbolt @michelebucelli let me know what you think |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
=======================================
Coverage 72.46% 72.46%
=======================================
Files 241 241
Lines 38646 38646
Branches 6644 6644
=======================================
Hits 28004 28004
Misses 10407 10407
Partials 235 235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
michelebucelli
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quadrature_modifier_TRI3andQuadrature_modifier_TET4settings from all four Niederer CEP benchmark solver inputs.niederer_benchmark_ECGs_quadraturetoniederer_benchmark_ECGs.Rationale
The benchmark volume mesh contains 420,000 HEX8 elements, while its boundary meshes contain only QUAD4 elements. The removed quadrature settings only used by the TRI3 face and TET4 volume quadrature rules, so they have no effect on this benchmark.
Renaming the benchmark and its test avoids implying that the case exercises modified simplex quadrature or validates conduction-velocity behavior across mesh resolutions. The reference result files are moved without modification.
Closes #588.
Related discussion: #587