-
Notifications
You must be signed in to change notification settings - Fork 56
FE Quadrature Phase 01 abstract contract #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4e47613
3bdfb91
3fb5364
4749c70
47a7985
2d4f8ed
1154fe8
690a92c
e6dd7e9
b831ea1
1e117c2
35cc8fe
42b23df
f412876
3a6af11
c5e934f
b34bfb3
a2f1677
a07b87b
fbf3630
6110849
593f765
4449885
454c7dd
f9ec988
2e48f4c
0b4d7bf
02aff30
bad9188
752bbee
fba6733
b1433cb
ce8ca07
d66e30c
e8d3680
42c9e9e
4feee78
6fb1dad
970f3c0
1c28f9e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -266,11 +266,17 @@ file(GLOB SOLVER_FE_MATH_SRCS CONFIGURE_DEPENDS | |
| FE/Math/*.h | ||
| ) | ||
|
|
||
| file(GLOB SOLVER_FE_QUADRATURE_SRCS CONFIGURE_DEPENDS | ||
| FE/Quadrature/*.cpp | ||
| FE/Quadrature/*.h | ||
| ) | ||
|
|
||
| list(APPEND CSRCS | ||
| ${SOLVER_CORE_SRCS} | ||
| ${SOLVER_FE_COMMON_SRCS} | ||
| ${SOLVER_FE_BASIS_SRCS} | ||
| ${SOLVER_FE_MATH_SRCS} | ||
| ${SOLVER_FE_QUADRATURE_SRCS} | ||
| ) | ||
|
Comment on lines
+269
to
280
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't it be better to have separate In my opinion this would encourage the clean separation of the different modules, and it might be a good idea to start implementing it at least for the newly refactored parts of the library.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zasexton I agree with @michelebucelli; better to use CMake to manage sub-directories. |
||
|
|
||
| # Set PETSc interace code. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this right, the purpose of this is to fix the
make docrecipe (whereas as of now the documentation would have to be built by callingdoxygenmanually from the repository root folder). Is this correct?If so, is the documentation now generated into the build folder, or into the source folder as in the current main branch?