feat: Group messages by sender and date#444
Closed
Namaneo wants to merge 1 commit into
Closed
Conversation
Contributor
|
Issue in PR - O(n) indexWhere on every build — _messageIndex scans the entire message list on every rebuild of every bubble. In a conversation with 500 messages, this means 500 × 500 = 250,000 comparisons per full rebuild. The index (or the pre-computed isFirstInGroup/isLastInGroup values) should be passed down from the parent as a constructor parameter instead. Opening PR #445 for the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to group messages by sender and date.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
This likely addresses #128.