Conversation
|
Hey @zivy, just wanted to mention that I think the |
Use bash as the shell for all OS instead of bash for macos/linux and pwsh for windows. Instead of passing environment variables via configure.vars to remotes::install_git, set them via Sys.setenv() in R before calling install_git. This works across all OSs. For some reason configure.vars set the environment variables on linux/mac but not on windows.
zivy
force-pushed
the
streamlineGHWorkflow
branch
from
4f4c63a to
b8cce57
Compare
|
Hey @Artur-man, Good catch, appreciate the quick response (I didn't even have a chance to see if the CI passed 😄). I think I've found a solution that will harmonize things across the three platforms, setting the environment variables prior to calling the As I'm not working on a windows machine, I'll see what happens with the CI and would appreciate it if you could try this solution on a windows machine. If this indeed works on all platforms, then we've got a nice consistent solution that is easier to maintain as we won't have to treat windows as "special". |
|
Thanks @zivy will do, but it seems like setting env from R workspace have worked. i will be in Italy for 1.5 weeks after that I can try again :D |
2 participants
Use bash as the shell for all OS instead of bash for macos/linux and pwsh for windows.