Skip to content

Support Swift 4.2 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppaulojr wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support Swift 4.2 #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
253878e
Support Swift 4.2
ppaulojr May 20, 2019
be89782
Update Simplicity.podspec
ppaulojr May 20, 2019
d4f51b4
Update Simplicity.podspec
ppaulojr May 20, 2019
c1af751
Update Simplicity.podspec
ppaulojr May 20, 2019
57379ba
Fix for Swift 4.2
ppaulojr May 20, 2019
d44856b
Merge branch 'master' of https://github.com/ppaulojr/Simplicity
ppaulojr May 20, 2019
fdf2644
Drop iOS 8
ppaulojr May 20, 2019
2221dfc
Fix warnings
ppaulojr May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .swift-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0
4.2
2 changes: 1 addition & 1 deletion Simplicity.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Pod::Spec.new do |s|
s.name = "Simplicity"
s.version = "2.0.3"
s.version = "2.0.4"
s.summary = "A simple way to login with Facebook or Google on iOS"

s.description = <<-DESC
Expand Down
2 changes: 1 addition & 1 deletion Simplicity/LoginProviders/Facebook.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public class Facebook: OAuth2 {
let range = urlScheme.range(of: "\\d+", options: .regularExpression) else {
preconditionFailure("You must configure your Facebook URL Scheme to use Facebook login.")
}
let clientId = urlScheme.substring(with: range)
let clientId = String(urlScheme[range])
let authorizationEndpoint = URL(string: "https://www.facebook.com/dialog/oauth")!
let redirectEndpoint = URL(string: urlScheme + "://authorize")!

Expand Down
2 changes: 1 addition & 1 deletion Simplicity/LoginProviders/VKontakte.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class VKontakte: OAuth2 {
let range = urlScheme.range(of: "\\d+", options: .regularExpression) else {
preconditionFailure("You must configure your VK URL Scheme to use VK login.")
}
let clientId = urlScheme.substring(with: range)
let clientId = String(urlScheme[range])
let authorizationEndpoint = URL(string: "https://oauth.vk.com/authorize")!
Copy link
Copy Markdown

@JerwinPRO JerwinPRO Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have error about undeclared URL? because Foundation is not imported here.

let redirectEndpoint = URL(string: urlScheme + "://authorize")!

Expand Down