feat(notifications): add GET/HEAD support to generic webhooks#125
Open
Shlok-Zanwar wants to merge 1 commit into
Open
feat(notifications): add GET/HEAD support to generic webhooks#125Shlok-Zanwar wants to merge 1 commit into
Shlok-Zanwar wants to merge 1 commit into
Conversation
Resolves Skyfay#123 - Adds GET and HEAD to GenericWebhookSchema enum - Omits request body on GET and HEAD requests in GenericWebhookAdapter - Verifies boolean return value from adapter.send() across SystemNotificationService and job completion pipeline to properly record delivery failures - Adds explicit GET and HEAD unit tests
Owner
|
@Shlok-Zanwar Thanks! I'll take a look at the code tomorrow, and then it will be included in the next release. Thank you very much. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #123
This PR implements support for
GETandHEADmethods in the Generic Webhook notification adapter.Changes:
GETandHEADto theGenericWebhookSchemaenum.GenericWebhookAdapterto explicitly omit the JSON request body when sendingGETorHEADrequests, preventingfetch()from throwing aTypeError.SystemNotificationServiceand job completion pipelines to check for the explicitbooleanreturn value fromadapter.send(), fixing a bug where webhook transmission failures (e.g. DNS errors or timeouts) were falsely logged as successes.