Support local files in BpkVideoPlayer#2750
Conversation
Generated by 🚫 Danger Kotlin against b716d3c |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds support for playing locally cached video files in BpkVideoPlayer by switching from an HTTP-only Media3 data source to DefaultDataSource, and updates docs to reflect the new accepted videoUrl inputs.
Changes:
- Replace
DefaultHttpDataSource-only configuration withDefaultDataSourceso non-HTTP URIs (e.g., local files) are supported. - Update VideoPlayer documentation to mention local file path support.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/compose/VideoPlayer/README.md | Documents that videoUrl can now be a local file path (in addition to remote URLs). |
| backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/videoplayer/internal/PlayerFactory.kt | Switches ExoPlayer media source factory to DefaultDataSource to allow local/file URIs. |
Generated by 🚫 Danger Kotlin against 944614f |
What changed
Why
The previous HTTP-only data source rejected local cache paths with `MalformedURLException: no protocol`.
Validation
detektpassed.Screen_recording_20260716_152216.mp4
Screen_recording_20260716_151634.mp4