Add Stellar DEX source integration tests with mocked Horizon#60
Open
Jennylila wants to merge 1 commit into
Open
Add Stellar DEX source integration tests with mocked Horizon#60Jennylila wants to merge 1 commit into
Jennylila wants to merge 1 commit into
Conversation
Implement midpoint orderbook price derivation and cover all seven Horizon scenarios with Jest mocks so regressions in price logic are caught without network calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds integration tests for
src/services/sources/stellarDex.jswith a mocked Horizon client so orderbook price derivation can be verified without real network calls. It also updates the Stellar DEX source to use midpoint pricing and propagate Horizon errors as required by the test scenarios.Related Issue
Closes #33
Changes
📈 Stellar DEX Price Derivation
src/services/sources/stellarDex.jsderivePriceFromOrderbook()to compute prices from Horizon orderbook data.nullgracefully when both sides are empty.🧪 Stellar DEX Integration Tests
test/stellarDex.test.jsstellar-sdkServerwith Jest (no real Horizon calls).0.115from ask0.12and bid0.11).Verification Results
stellarDex.js≥ 90%