Repository navigation
assert fix + tweaks - #364
Merged
Merged
Conversation
FreeBSD 13 was EOLed long ago and its images have now stopped
functioning:
+ pkg install -y bison cmake git gmp python3 devel/py-pytest
Updating FreeBSD repository catalogue...
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/meta.conf: Failed writing received data to disk/application
repository FreeBSD has no meta file, using default settings
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/meta.txz: Failed writing received data to disk/application
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/data.pkg: Failed writing received data to disk/application
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/data.tzst: Failed writing received data to disk/application
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/packagesite.pkg: Failed writing received data to disk/application
Unable to update repository FreeBSD
Error updating repositories!
pkg: Failed to fetch http://pkg.FreeBSD.org/FreeBSD:13:amd64/latest/packagesite.tzst: Failed writing received data to disk/application
This was discovered while trying to 100% Clang’s -Wstring-conversion. I am unsure if this is an argument _for_ compiler warnings or a cautionary tale about the perils of a lack of negative testing.
Clang complains about this idiom. Interestingly (?) apparently I was aware of this some time ago¹ but did not realise the implications in this context. ¹ See compiler.h in d6fc4fd.
I am not sure why these were not `ASSERT`¹ to begin with. They certainly look like they could advantage performance. ¹ A macro that expands to `assert` plus some performance hints to the compiler.
Smattr
force-pushed
the
smattr/1d9e52fd-fb03-4baf-8add-316f03b8c666
branch
from
October 16, 2026 00:53
2881044 to
5f7e5f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.