Skip to content

Fix apple platforms other than macOS#243

Merged
ids1024 merged 1 commit into
Smithay:masterfrom
dtolnay-contrib:apple
May 12, 2026
Merged

Fix apple platforms other than macOS#243
ids1024 merged 1 commit into
Smithay:masterfrom
dtolnay-contrib:apple

Conversation

@dtolnay
Copy link
Copy Markdown
Contributor

@dtolnay dtolnay commented Apr 23, 2026

Fixes #242.

Tested:

  • cargo check --target=aarch64-apple-darwin
  • cargo check --target=aarch64-apple-ios
  • cargo check --target=aarch64-apple-tvos
  • cargo check --target=aarch64-apple-visionos
  • cargo check --target=aarch64-apple-watchos

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (7e4d3ac) to head (6674048).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   85.47%   86.20%   +0.72%     
==========================================
  Files          14       16       +2     
  Lines        1818     2000     +182     
==========================================
+ Hits         1554     1724     +170     
- Misses        264      276      +12     
Flag Coverage Δ
macos-latest 85.51% <ø> (?)
ubuntu-latest 85.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ids1024 ids1024 merged commit 9252986 into Smithay:master May 12, 2026
12 checks passed
@ids1024
Copy link
Copy Markdown
Member

ids1024 commented May 12, 2026

Thanks!

Perhaps we could have some cargo check tests on CI. Though it looks there is a macOS CI test already. (Cirrus CI is shutting down, so the FreeBSD CI is going to need to be replaced or removed.)

@dtolnay dtolnay deleted the apple branch May 13, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tvOS compile fails

2 participants