fix: use lossy UTF-8 conversion for device sysname to avoid panic#98
Open
neuralbroker wants to merge 1 commit into
Open
fix: use lossy UTF-8 conversion for device sysname to avoid panic#98neuralbroker wants to merge 1 commit into
neuralbroker wants to merge 1 commit into
Conversation
The sysname() method used to_str().expect() which panics when a USB device's kernel sysname contains non-UTF-8 bytes (e.g. certain USB microphones with corrupted manufacturer strings). Use to_string_lossy() instead, matching the behavior of the name() method. Fixes pop-os/cosmic-epoch#2105 where cosmic-comp crashes with: 'Device sysname is no valid utf8: Utf8Error { valid_up_to: 126, error_len: Some(1) }'
Member
|
Can you prove that this is indeed true? That string is most likely controlled by the kernel or udev rather than by the device. The linked issue describes a different problem, the panic log you provide does not align with the one in that issue, what's the source of it? Something similar to running |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The sysname() method used to_str().expect() which panics when a USB device's kernel sysname contains non-UTF-8 bytes. Use to_string_lossy() instead, matching the behavior of the name() method.
Fixes pop-os/cosmic-epoch#2105 where cosmic-comp crashes with:
Device sysname is no valid utf8: Utf8Error { valid_up_to: 126, error_len: Some(1) }