PPR C++ Tracer Bullet#556
Open
mkolodner-sc wants to merge 12 commits intomkolodner-sc/cpp-infrastructurefrom
Open
PPR C++ Tracer Bullet#556mkolodner-sc wants to merge 12 commits intomkolodner-sc/cpp-infrastructurefrom
mkolodner-sc wants to merge 12 commits intomkolodner-sc/cpp-infrastructurefrom
Conversation
mkolodner-sc
requested review from
kmontemayor2-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
mkolodner-sc
force-pushed
the
mkolodner-sc/cpp_ppr_tracer
branch
from
4d2db2a to
cfcb8cb
Compare
mkolodner-sc
changed the base branch from
main
to
mkolodner-sc/cpp-infrastructure
mkolodner-sc
force-pushed
the
mkolodner-sc/cpp_ppr_tracer
branch
from
7009d70 to
dd118ef
Compare
mkolodner-sc
commented
Apr 1, 2026
| // Allocate per-seed, per-node-type tables. | ||
| // .assign(n, val) fills a vector with n copies of val — like [val] * n in Python. | ||
| ppr_scores_.assign(batch_size_, | ||
| std::vector<std::unordered_map<int32_t, double>>(num_node_types_)); |
Collaborator
Author
There was a problem hiding this comment.
Note to self:
Look into std::map -> hashmap
Look into unordered set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO