feat: add missing replay-verification reject fixture for SR gate policy#281
Open
mdheller wants to merge 1 commit into
Open
feat: add missing replay-verification reject fixture for SR gate policy#281mdheller wants to merge 1 commit into
mdheller wants to merge 1 commit into
Conversation
…cy (#259) Adds reject-sr-gate-policy-replay.json: requireReplayVerified=false is rejected by the sr-gate-policy schema (const: true). Completes the five required negative-fixture scenarios from the acceptance criteria: inconsistent units, allowControlAuthority=true, missing replay verification, platform-dynamics direct eligible, and shape errors. 23 PROMETHEUS SR checks now pass. Closes #259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/fixtures/symbolic-regression/reject-sr-gate-policy-replay.json: a policy fixture withrequireReplayVerified: false, which the SR gate policy schema rejects viaconst: trueconstraintallowControlAuthority=true, missing replay verification,platform_dynamicsdirecteligiblepromotion, and complexity/NMSE/shape errorsCloses #259
Test plan
make validate-prometheus-srpasses (23/23)reject-sr-gate-policy-replay.jsonis correctly rejected