feat: expose sandbox run evidence refs for workroom consumption, add teardown validation#283
Open
mdheller wants to merge 1 commit into
Open
feat: expose sandbox run evidence refs for workroom consumption, add teardown validation#283mdheller wants to merge 1 commit into
mdheller wants to merge 1 commit into
Conversation
…teardown validation (#256) Adds runtime_teardown_complete validation to validate_runtime_sandbox_run.py: parity must be runtime_observed, evidence and receipt refs are required, failure codes must be empty, teardownState must be teardown_complete. Adds runtime-sandbox-run.teardown.valid.json: valid teardown_complete fixture with workroom receipt (receipt://devsecops-workroom/sandbox-evidence/...). Adds runtime-sandbox-run.teardown.missing-evidence.invalid.json: invalid teardown_complete with empty evidenceRefs and receiptRefs. Adds shared-receipt fixture and teardown fixture to VALID_FIXTURES. Validator now covers all 4 states: requested, allocated, failed, and teardown_complete. Wires validate-runtime-sandbox-run into make validate. Closes #256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_runtime_sandbox_run.pyto validateruntime_teardown_completestatus:parity=runtime_observed, non-emptyevidenceRefs/receiptRefs, nofailureCodes,teardownState=teardown_completeruntime-sandbox-run.teardown.valid.json: teardown_complete fixture with workroom-consumable receipt ref (receipt://devsecops-workroom/sandbox-evidence/...), demonstrating stableevidence://+receipt://refs for workroom consumptionruntime-sandbox-run.teardown.missing-evidence.invalid.json: invalid teardown with empty evidence/receipt refsshared-receiptandteardownfixtures to VALID_FIXTURES; all 4 required states (requested, allocated, failed, teardown_complete) are now semantically validatedvalidate-runtime-sandbox-runintomake validateCloses #256
Parent: SocioProphet/prophet-platform#519
Test plan
make validate-runtime-sandbox-runpasses (5 valid + 2 invalid correct)make validatepasses (aggregate)runtime-sandbox-run.teardown.missing-evidence.invalid.jsonis correctly rejected