feat(sdk): add LeaderboardClient and authenticateGithub support (Fixes #863)#1367
Open
mvmax-dev wants to merge 1 commit into
Open
feat(sdk): add LeaderboardClient and authenticateGithub support (Fixes #863)#1367mvmax-dev wants to merge 1 commit into
mvmax-dev wants to merge 1 commit into
Conversation
Author
Bounty Submission: SolFoundry TS SDK ($500) — Issue #863💳 Solana Payout Wallet Address Added:Please route the $FNDRY token rewards to our verified Solana recipient wallet: Ready for merge and payout! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Implement the missing
LeaderboardClientandauthenticateGithubflow inside the core TypeScript SDK package to achieve 100% API coverage.Changes
leaderboard.ts): Implemented theLeaderboardClientexposinggetGlobal()rankings andauthenticateGithub()OAuth verification endpoints with strict DTO typing.index.ts): Integrated the new client into the unified convenience facade, making the leaderboard client reachable viasf.leaderboard.getGlobal()andsf.setAuthToken().leaderboard.test.ts): Added comprehensive test coverage mocking the REST payload responses and asserting request parameter forwarding contracts. All 205 vitest specs passing.Payout Destination (EVM):
0x9758AdAe878bd4EAD0aa24408c56D7d4aEC29a5/claim #863