SONARJAVA-6397 Add Mall spring project to ruling test#5630
SONARJAVA-6397 Add Mall spring project to ruling test#5630leonardo-pilastri-sonarsource wants to merge 3 commits into
Conversation
| [submodule "its/sources"] | ||
| path = its/sources | ||
| url = https://github.com/SonarSource/ruling_java.git | ||
| branch = lp/add-spring-ruling |
There was a problem hiding this comment.
⚠️ Quality: Submodule .gitmodules points to feature branch instead of master
The .gitmodules file now specifies branch = lp/add-spring-ruling, which is a feature branch in the ruling_java repository. If this branch is deleted or not merged into the default branch of that repo before this PR lands on master, the submodule tracking will break for anyone doing git submodule update --remote. Typically submodules should track a stable branch (e.g., master or main). Either merge the feature branch in ruling_java first and remove the branch line (so it defaults to the remote HEAD), or update it to point to the stable branch after the ruling_java PR is merged.
Remove the branch line so the submodule tracks the default branch of the remote (after merging lp/add-spring-ruling into the default branch of ruling_java):
[submodule "its/sources"]
path = its/sources
url = https://github.com/SonarSource/ruling_java.git
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
Code Review
|
| Auto-apply | Compact | Unblock |
|
|
|
Was this helpful? React with 👍 / 👎 | Gitar
|





Summary by Gitar
mallspring project to the integration ruling tests.its/sourcesto tracklp/add-spring-rulingbranch..jsonfiles) for various SonarJava rules inits/ruling/src/test/resources/mall/.This will update automatically on new commits.